This PR (HEAD: fe6720d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Jamal Carvalho:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/2f3a2a0f-2c8f-42dc-87fc-35ad4ea6cd9a

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 2: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/2f3a2a0f-2c8f-42dc-87fc-35ad4ea6cd9a

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Jamal Carvalho:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: dd931e4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from leo steve:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Hyang-Ah Hana Kim:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4ef79603-c794-4a3b-81b9-037bdd2dd747

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 3: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/4ef79603-c794-4a3b-81b9-037bdd2dd747

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 42ec3e8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from leo steve:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Jamal Carvalho:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b9782042-27cf-4c72-b039-03bd2ae738e6

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 4: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b9782042-27cf-4c72-b039-03bd2ae738e6

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 98a9bdb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from leo steve:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Jamal Carvalho:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from leo steve:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from leo steve:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from Jamal Carvalho:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/00e33dfe-207f-4046-9cbb-1a3691ef327a

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

Message from kokoro:

Patch Set 5: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/00e33dfe-207f-4046-9cbb-1a3691ef327a

Please don’t reply on this GitHub thread. Visit golang.org/cl/425835.
After addressing review feedback, remember to publish your drafts!

This was never merged. #1831 is still open. It really looks like this will fix it. Any chance of some help form the team here?

I also ran into this issue, on a CGO project which requires ldflags+extflags on macOS. The impact is that my project cannot test or debug tests on VSC on macOS.

This PR (HEAD: cc35f55) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/425835.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

This PR (HEAD: f9633df) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/425835.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.